chore: ux-improvements-and-fixes - #41
Closed
its-mash wants to merge 5 commits into
Closed
Conversation
This commit addresses two key issues and enhances the auto-start functionality: Issue #40: Settings save feedback - Added Toast notification system to UI package - Success toast shows when settings are saved - Error toast shows if save fails - Auto-dismiss after 3 seconds with manual close option - Added comprehensive unit and e2e tests for toast functionality Issue #39: Hidden console windows for docker servers - Fixed stdio servers opening visible terminal windows on Windows - Added CREATE_NO_WINDOW flag to child process creation - Only affects Windows builds via conditional compilation Auto-start improvements: - Changed default auto_launch to true for gateway apps - Auto-enable on first launch without requiring Settings UI interaction - Added startup.autostart_configured flag to respect user choices - User can still disable in Settings and it persists across launches Deep link registry documentation: - Updated spike doc with correct HKLM vs HKCU registry behavior - NSIS installs write to HKCU (per-user) - MSI installs write to HKLM (per-machine) - Both merge into HKCR at runtime Tests: - Added Toast component unit tests - Added useToast hook unit tests - Extended SettingsPage e2e tests for startup settings - Added toast visibility and dismissal tests Fixes #39, #40
Extended toast notification coverage to all user-facing save and change operations in the desktop app. Changes: - Added toast to ConfigEditorModal save operation (success/error) - Added toast to FeatureSetsPage create operation (success/error) - Added toast to FeatureSetsPage delete operation (success/error) - All toasts show descriptive messages with operation details - All toasts auto-dismiss after 3 seconds with manual close option Tests: - Added e2e tests for feature set create/delete toast notifications - Added e2e tests for config editor save toast notifications - Tests verify toast visibility, content, and auto-dismissal All save/change operations now provide consistent visual feedback to users.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| // This is tricky with Monaco editor, so we'll just test the error state | ||
| const editor = page.locator('.monaco-editor'); | ||
| if (await editor.isVisible()) { | ||
| const saveButton = page.getByRole('button', { name: /Save/i }); |
| @@ -0,0 +1,160 @@ | |||
| import { describe, it, expect, vi, beforeEach } from 'vitest'; | |||
| import { render, screen, waitFor } from '@testing-library/react'; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.